Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Misc updates and "bugfixes" #23

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Misc updates and "bugfixes" #23

wants to merge 1 commit into from

Conversation

brewcore
Copy link

These are some quick changes we found useful. Not really bugs, but some of these do break the build unnecessarily.

  • Updated Phing to 2.6.
  • Stopped failing on debug code detection because many popular modules (views specifically) include debugging options.
  • Excluded coder module from php file set for analysis because it contains bad code, but is useful.

Stopped failing on debug code detection because many popular modules (views) include debugging options.
Excluded coderreview from php file set because it does bad things, but is useful.
@xendk
Copy link
Member

xendk commented Oct 14, 2013

The reason the rule fails instead of only warning, is that we work with different assumptions. We don't check core and contrib modules, as it's not code we wrote. We put all contrib code in contrib/ or libraries/, which is two patterns that's explicitly ignored in phing-drupal-template.

The successor to phing-drupal-template, https://github.com/reload/drake_ci , works on the same assumption.

Any particular reason for including contrib in the checking?

@brewcore
Copy link
Author

That makes sense. We like to check pretty much every piece of code on a site so that we're aware of any potential issues a contributed module may introduce. I get that not everyone would want that workflow.

In the future we're hoping to build a system that we can use to test community code and updates before deploying them to sites.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants