Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Allow deploying sites via Aegir (not just drush site-install) #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link

@dsnopek dsnopek commented Nov 12, 2013

The current build.xml provides a "site-install" target which uses "drush site-install" to install the site.

This pull request converts "site-install" to "deploy" and allows you to choose in the build.properties which "deploy.type" you would like - either: drush or aegir. (Note: the "site-install" target is retained as an alias to deploy.)

I could envision even deploying to Pantheon or something else interesting in the future! :-)

@xendk
Copy link
Member

xendk commented Nov 12, 2013

Well, the site-install target primary use was to provide somewhere to run coder and tests, how does this play with deploy?

@dsnopek
Copy link
Author

dsnopek commented Nov 12, 2013

All of that should still work! I'll test it a little later today.

@dsnopek
Copy link
Author

dsnopek commented Nov 12, 2013

It looks like some minor changes will be necessary to get the 'simpletest' and 'coder-review' targets working with Aegir. The issue is that those targets assume that the Drupal site is installed in sites/default/settings.php so that only --root is necessary to Drush. However, Aegir uses multisite and so we'll need to pass either both --root/--uri to all those calls OR just use the drush alias for the site. I'll post an update once I've figured out how to handle that.

…stalled site explicit. Previously the Drush commands pm-list and pm-enable were called without depending on an installed site, even though they require one!
@dsnopek
Copy link
Author

dsnopek commented Nov 19, 2013

Ok, I made some minor changes that allow 'deploy' to work with both the 'simpletest' and 'coder-review-d7' targets. The primary change is adding an explicit dependency on 'deploy' in any target that requires an installed site to work, ie. anything that calls the pm-list and pm-enable drush commands.

Please let me know what you think!

@dsnopek
Copy link
Author

dsnopek commented Nov 19, 2013

I just realized that the reason I had to make the changes to the coder-review target are because I'm using coder 7.x-2.0, rather than 7.x-1.0. This is because that's version of coder that was actually installed on the site I'm using this with. :-)

So, this pull request also includes the changes from #25 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants