Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define MOD_VERSION_STRING "mod-1.35.3" #3

Open
mike2nl opened this issue Aug 1, 2018 · 3 comments
Open

#define MOD_VERSION_STRING "mod-1.35.3" #3

mike2nl opened this issue Aug 1, 2018 · 3 comments

Comments

@mike2nl
Copy link

mike2nl commented Aug 1, 2018

Have you look for this feature in other issues and in the wiki?
-> yes

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
-> About your comment in sonoff.ino
#define MOD_VERSION_STRING "mod-1.35.3" // Would be great to have a macro that fills this from VERSION ...

Describe the solution you'd like
A clear and concise description of what you want to happen.
-> in the xdrv_02_webserver,ino search for:
--> String func = FPSTR(HTTP_SCRIPT_INFO_BEGIN);
..
..
--> func += F(D_PROGRAM_VERSION "}2"); func += my_version;

Then add a new line:
--> func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;

It can be done also as if:
#ifdef MOD_VERSION_STRING
func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;
#endif

D_PROGRAM_VERSION_MOD has to be added to all the language files.
This fix is for the web page only.

When it is needed in status 0 in json format then we have to add some parts in the json creation.
For that i must search a little bit more in all the snprintf calls for json. That's then the define for
#define D_JSON_VERSION "Version" in the file i18n.h

Here a screenshot and yes i forgot the next line command and it's the idea behind it:

information mod version

And here the corrected one and the name can be like 'Modded Version' or something else:
information mod version corrected

@reloxx13
Copy link
Owner

This looks difrent to me, also if you like just make pull requests instead of writing so much :D
grafik

Your hints are very nice! Also it would be better to post those on the official Tasmota Repo, if it gets denied we can add it here, thats why i made this "mod".

Its rather a collection of some changes which got denied and also to provide latest dev builds.

@reloxx13
Copy link
Owner

this is upcoming:
grafik

@mike2nl
Copy link
Author

mike2nl commented Aug 16, 2018

@reloxx13
Ahh, i see what you mean about that's comming. No issue at all because
i can change that for the test.

About your second posting to message that directly to tasmota.

1st: tasmota is a very good peace os software/firmware and i'm really
happy that some people are working on it! Otherwise i would never
work together with the Yeti guys in the meaning of much, much
status 0 information and know how transfer. As a early beta tester now for
the new pages inside the Yeti app. E.G. to show the sensor values from
different sonoff devices.

2nd: I'm not OK with all things in tasmota about my little bit more then 30 years
(33) but that's normal and 100% ok. That's how the world is spinning. Under other
circumstances as happend some weeks ago i would more then happy to help
with my experience. Help is for me more important then a get back. But after
i made 2 bug reports i got that kind of answers where nothing stays on. When
i will to help and give feedback about my findings and i get childish answers?
Sorry that's a no go for me becuase i'm not a beginner and my really very little
free time is more worth then childish answers. I have no time for that.
It's possible me but that i am.

So i came here to you after i found it and when i read your type of answers...
here it is very different.

-> make pull requests instead of writing so much :D
I love to write because in the beginning when i was 18 and started with radar
technic and later software, all learned by millitary, i had to write a lot of
scripts, docs of how to, two real books too and a lot of other stuff. So:D ...

reloxx13 pushed a commit that referenced this issue Aug 26, 2018
reloxx13 pushed a commit that referenced this issue Sep 3, 2018
Move LM75ADDetect() to FUNC_EVERY_SECOND
reloxx13 pushed a commit that referenced this issue Sep 28, 2018
reloxx13 pushed a commit that referenced this issue Mar 18, 2019
Renamed SM16716 select and added our enhancement to feature list
reloxx13 pushed a commit that referenced this issue Apr 5, 2019
reloxx13 pushed a commit that referenced this issue Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants