-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#define MOD_VERSION_STRING "mod-1.35.3" #3
Comments
@reloxx13 About your second posting to message that directly to tasmota. 1st: tasmota is a very good peace os software/firmware and i'm really 2nd: I'm not OK with all things in tasmota about my little bit more then 30 years So i came here to you after i found it and when i read your type of answers... -> make pull requests instead of writing so much :D |
Move LM75ADDetect() to FUNC_EVERY_SECOND
Renamed SM16716 select and added our enhancement to feature list
Have you look for this feature in other issues and in the wiki?
-> yes
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
-> About your comment in sonoff.ino
#define MOD_VERSION_STRING "mod-1.35.3" // Would be great to have a macro that fills this from VERSION ...
Describe the solution you'd like
A clear and concise description of what you want to happen.
-> in the xdrv_02_webserver,ino search for:
--> String func = FPSTR(HTTP_SCRIPT_INFO_BEGIN);
..
..
--> func += F(D_PROGRAM_VERSION "}2"); func += my_version;
Then add a new line:
--> func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;
It can be done also as if:
#ifdef MOD_VERSION_STRING
func += F("}1" D_PROGRAM_VERSION "}2"); func += MOD_VERSION_STRING;
#endif
D_PROGRAM_VERSION_MOD has to be added to all the language files.
This fix is for the web page only.
When it is needed in status 0 in json format then we have to add some parts in the json creation.
For that i must search a little bit more in all the snprintf calls for json. That's then the define for
#define D_JSON_VERSION "Version" in the file i18n.h
Here a screenshot and yes i forgot the next line command and it's the idea behind it:
And here the corrected one and the name can be like 'Modded Version' or something else:
The text was updated successfully, but these errors were encountered: