Skip to content

Conversation

@Citrullin
Copy link

Adds an OLED Display example.

@relu91 relu91 changed the base branch from dev to master August 23, 2021 15:53
@relu91 relu91 changed the base branch from master to dev August 23, 2021 15:54
Copy link
Owner

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good just one minor concern. Waiting for #11 before merging it.

Written by Limor Fried/Ladyada for Adafruit Industries.
BSD license, check license.txt for more information
All text above, and the splash screen must be included in any redistribution
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text actually states that we should keep this.... if you don't have a strong preference I'd keep it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the whole code and wrote a different app. Just used the existing file. You can also see that in the diff. But I don't really care.

@relu91 relu91 merged commit 38375ac into relu91:dev Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants