Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the TO(n) key codes issue. #747

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix the TO(n) key codes issue. #747

merged 1 commit into from
Oct 19, 2022

Conversation

yoichiro
Copy link
Collaborator

Fix #746

This pull request fixes the issue that the TO(n) key codes are different from them of current QMK Firmware.

See: qmk/qmk_firmware#17989

@yoichiro
Copy link
Collaborator Author

yoichiro commented Oct 19, 2022

When testing behaviors of TO(0), TO(1) and TO(2) using my Lunakey Macro keyboard, they normally work.

  1. I built a firmware with the latest master branch of QMK Firmware. Then, I flashed it to the MCU of my keyboard.
  2. I assigned TO(0), TO(1) and TO(2) to each layer with fixed Remap.
  3. I pressed TO(n) key and confirmed to move to each target layout normally.
  4. I unpluged and re-plug the USB cable from/to the keyboard, and I confirmed that each TO(n) was normally fetched from the MCU and was displayed on the Remap.

@yoichiro yoichiro merged commit 4b3f29f into main Oct 19, 2022
@yoichiro yoichiro deleted the fix-to-key-code-issue branch October 19, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data is not correct in TO keycode
1 participant