Skip to content

Conversation

@beeequeue
Copy link
Contributor

@beeequeue beeequeue commented May 8, 2025

What is the motivation for this pull request?

Closes #1058

What is the current behavior?

Some bundlers may bundle the wrong code for node vs. browsers.

What is the new behavior?

Bundler have more standardized information to use to determine what files to use.

Checklist:

@beeequeue beeequeue requested a review from remarkablemark as a code owner May 8, 2025 16:53
@remarkablemark remarkablemark changed the title feat: Improve exports manifest feat: improve exports manifest May 8, 2025
Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (d01523b) to head (c1e1f8d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files           7        7           
  Lines         145      145           
  Branches       30       30           
=======================================
  Hits          135      135           
  Misses          8        8           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remarkablemark remarkablemark merged commit 890ddb3 into remarkablemark:master May 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve exports manifest

2 participants