Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test case #24

Closed
wants to merge 1 commit into from
Closed

add failing test case #24

wants to merge 1 commit into from

Conversation

rburgst
Copy link

@rburgst rburgst commented May 29, 2020

What is the motivation for this pull request?

bug

What is the current behavior?

fails parsing a more complicated html with scripts, comments, audio/video tags

What is the new behavior?

havent fixed anything yet, this just shows the problem

Checklist:

  • Tests
  • Documentation

@rburgst
Copy link
Author

rburgst commented May 29, 2020

I found out that if I remove

<p>&nbsp;</p>

and

<noscript>...</noscript>

then the test succeeds

however the nesting is still wrong. (2nd audio tag gets rendered into the first one)

@rburgst
Copy link
Author

rburgst commented May 29, 2020

note that I also tried sanitizing the html beforehand (as suggested here remarkablemark/html-react-parser#124), the result is still the same.

@rburgst
Copy link
Author

rburgst commented May 30, 2020

I guess the problem is that we cannot specify {xmlMode: true} to htmlparser2

@rburgst
Copy link
Author

rburgst commented May 30, 2020

see also remarkablemark/html-react-parser#158

@remarkablemark
Copy link
Owner

remarkablemark commented Jun 2, 2020

I fixed the issue with parsing HTML entities in the test runner (see explanation in issue #25 or 41679f9).

I also discovered that the jsdom version we're using is not properly parsing <noscript> children so I skipped those tests (see 40ade7e).

See PR #26

@rburgst rburgst closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants