Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rollup): allow for files to be nested in folders within outDir #1596

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Nov 10, 2024

What is the motivation for this pull request?

See rollup/plugins#1783

Closes rollup/plugins#1777

 @rollup/plugin-typescript  11.1.6  →  12.1.1
 rollup                     4.24.4  →  4.25.0

What is the current behavior?

Rollup build fails with error:

[!] (plugin typescript) RollupError: [plugin typescript] @rollup/plugin-typescript: Path of Typescript compiler option 'outDir' must be located inside the same directory as the Rollup 'file' option.

What is the new behavior?

Updated rollup.config.mjs:

  plugins: [
    typescript({
      compilerOptions: {
        outDir: 'dist',
      },
    )},
  ],

Checklist:

@remarkablemark remarkablemark added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 10, 2024
@remarkablemark remarkablemark self-assigned this Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb6472d) to head (2386e1b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1596   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        49        49           
=========================================
  Hits           151       151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

See rollup/plugins#1783

```
 @rollup/plugin-typescript  11.1.6  →  12.1.1
 rollup                     4.24.4  →  4.25.0
```
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.38 KB (0%) 188 ms (0%) 98 ms (+1024.43% 🔺) 286 ms

@remarkablemark remarkablemark merged commit 052d79d into master Nov 10, 2024
11 checks passed
@remarkablemark remarkablemark deleted the build/rollup branch November 10, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant