Skip to content

Conversation

@remarkablemark
Copy link
Owner

Fixes #242

What is the motivation for this pull request?

fix(attributes-to-props): fix attributes-to-props type Props

What is the current behavior?

type Props = Record<string, string>;

What is the new behavior?

type Props = Record<string, string> & {
  style: Record<string, string>;
}; 

Checklist:

  • Tests
  • Types

@remarkablemark remarkablemark added the bug Something isn't working label Apr 18, 2021
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 7.23 KB (0%) 145 ms (0%) 105 ms (+4.06% 🔺) 250 ms

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c9c3b02 on fix/types into 0ed9598 on master.

@remarkablemark remarkablemark merged commit b6b1004 into master Apr 18, 2021
@remarkablemark remarkablemark deleted the fix/types branch April 18, 2021 17:49
@remarkablemark
Copy link
Owner Author

Published v1.2.6:

npm:

npm i html-react-parser@1.2.6

Yarn:

yarn add html-react-parser@1.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong return types on attributesToProps

3 participants