Fix webpack error by reverting to react@15.3 for v0.2.0 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy and refactor code.
`./lib/html-to-dom-server.js` has been replaced with `html-dom-parser` package.
Remove the try-catch and require the DOM property configs from `react/lib/`. > ERROR in ./lib/property-config.js > Module not found: Error: Cannot resolve module > 'react/lib/HTMLDOMPropertyConfig'
Rename `build` to `build-unmin` and update `prepublish` to run `clean` before the build scripts.
This was referenced Nov 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the fix in #30 uses a try-catch to require the DOM property configs either from
react/lib/orreact-dom/lib/, this causes webpack to throw an error (albeit harmless):After some discussion with @struesdell in #29, semver will be used to account for react latest and <15.4.
Tasks:
lib/property-config.jsreact@15.3for v0.2.0 of this packagepackage.jsonand update npm scripts