Skip to content

Conversation

@remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Sep 7, 2021

Resolves #14

What is the motivation for this pull request?

BREAKING CHANGE: Update react-property to use property from latest react-dom 17 instead of 15.

What is the current behavior?

Uses property from react-dom 15:

What is the new behavior?

Uses property from react-dom 17:

Checklist:

  • Tests
  • Documentation

@codecov-commenter
Copy link

Codecov Report

Merging #22 (a54deb6) into master (6e263dd) will decrease coverage by 21.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##            master      #22       +/-   ##
============================================
- Coverage   100.00%   78.03%   -21.97%     
============================================
  Files            4        3        -1     
  Lines           32      132      +100     
  Branches         2       17       +15     
============================================
+ Hits            32      103       +71     
- Misses           0       18       +18     
- Partials         0       11       +11     
Impacted Files Coverage Δ
packages/react-property/lib/injection.js
...ckages/react-property/lib/HTMLDOMPropertyConfig.js
...ackages/react-property/lib/SVGDOMPropertyConfig.js
...act-property/lib/possibleStandardNamesOptimized.js 100.00% <0.00%> (ø)
packages/react-property/lib/index.js 76.80% <0.00%> (ø)
...ckages/react-property/lib/possibleStandardNames.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e263dd...a54deb6. Read the comment docs.

@remarkablemark remarkablemark merged commit 2844c0c into master Sep 7, 2021
@remarkablemark remarkablemark deleted the feat/react-property branch September 7, 2021 04:09
@remarkablemark
Copy link
Owner Author

Released react-property@2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support types from React@17 in react-property

3 participants