feat(react-property): create package for HTML and SVG DOM property configs #9
Conversation
Save to `package.json` devDependencies
These are React properties
These are React properties
The build script is similar to HTML DOM config except SVG does not have boolean or overloaded boolean attributes/properties.
And add "main" field in `package.json` so the file is included during npm publish.
talbet
left a comment
talbet
left a comment
There was a problem hiding this comment.
Really nice. You must have a lot of familiarity with the React internals, I've looked at them a bit, but wouldn't have come up with this. A few comments, but nothing I can see that would block this from going in.
| try { | ||
| fs.mkdirSync(LIB_DIR); | ||
| } catch (error) { | ||
| // throw error; |
There was a problem hiding this comment.
Should the error be re-thrown here if it is not a "directory already exists" error?
if (error.code !== 'EEXIST') throw error;
| } | ||
|
|
||
| /** | ||
| * HTML DOM property config. |
There was a problem hiding this comment.
Maybe we can add extra context to this comment? I wasn't sure what it was for at first. Something along the lines of: "an object containing HTML attributes and how they should be mapped to React props"
There was a problem hiding this comment.
I changed the wording slightly. Let me know if it makes sense.
| try { | ||
| fs.mkdirSync(LIB_DIR); | ||
| } catch (error) { | ||
| // throw error; |
There was a problem hiding this comment.
as above, we could handle this error if it is not expected
if (error.code !== 'EEXIST') throw error;
| var overloadedBooleanProperties = require('../../lib/html/overloaded-boolean-properties'); | ||
|
|
||
| var attributeMap = {}; | ||
| var attributeName; |
There was a problem hiding this comment.
Nice 👍 I haven't used var for such a long time I probably would have forgotten the scoping complications of var and loops.
There was a problem hiding this comment.
Thanks. I'm considering rewriting this to TypeScript but that can be an enhancement done later.
|
Released and published # npm
npm i -S react-property@0.1.0
# yarn
yarn add react-property@0.1.0 |
Relates to remarkablemark/html-react-parser#107
Would love to get your review @talbet