Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when ordering only virtual products #2

Closed
jasuten opened this issue Aug 15, 2019 · 2 comments
Closed

Error when ordering only virtual products #2

jasuten opened this issue Aug 15, 2019 · 2 comments

Comments

@jasuten
Copy link

jasuten commented Aug 15, 2019

PHP error on checkout when the order only contains virtual products, e.g. gift vouchers. Looks like it is because there is no shipping address on the order.

PHP Fatal error: Uncaught Error: Call to a member function getCountryId() on null in /app/code/Remarkety/Mgconnector/Serializer/AddressSerializer.php:28
Stack trace:
#0 /app/code/Remarkety/Mgconnector/Serializer/OrderSerializer.php(180): Remarkety\Mgconnector\Serializer\AddressSerializer->serialize(NULL)
#1 /app/code/Remarkety/Mgconnector/Observer/TriggerOrderUpdated.php(40): Remarkety\Mgconnector\Serializer\OrderSerializer->serialize(Object(Magento\Sales\Model\Order\Interceptor))
#2 /vendor/magento/framework/Event/Invoker/InvokerDefault.php(88): Remarkety\Mgconnector\Observer\TriggerOrderUpdated->execute(Object(Magento\Framework\Event\Observer))
#3 /vendor/magento/framework/Event/Invoker/InvokerDefault.php(74): Magento\Framework\Event\Invoker\InvokerDefault->_callObserverMethod(Object in /app/code/Remarkety/Mgconnector/Serializer/AddressSerializer.php on line 28,

@bnayalivne
Copy link
Contributor

Hey @jasuten, thanks for reporting, we will look into that

@bnayalivne
Copy link
Contributor

Issue fixed. Thanks for letting us know and sorry for the time it took.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants