Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel tag to links #350

Closed
wants to merge 1 commit into from
Closed

Add rel tag to links #350

wants to merge 1 commit into from

Conversation

juancarlosqr
Copy link

Hi,

For security reasons external links should be able to have a rel tag (.e.g. "noopener noreferrer"). More info here

I created a linkRel option to add the tag, similar to linkTarget

This is the first year I participate in the Hacktoberfest, so I'm open to any comments or feedback regarding my contribution 😉

Happy Hacktoberfest!

@blaiz
Copy link

blaiz commented Dec 3, 2019

This looks great! I also have a need for this prop. Hopefully this can be merged soon.

@benliger1987
Copy link

Any progress on merging this? Seems like a pretty crucial commit security wise

@fivetwelve
Copy link

fivetwelve commented Feb 12, 2020

Would be nice to be able to add optionally nofollow value in addition to those base ones.

@wchargin
Copy link

@rexxars: Friendly ping :-) if you get a chance to look at this, that’d
be lovely, since it enables fixing a security hole. It looks like the PR
still merges cleanly into origin/master, and the proposed patch looks
nice and clean.

@madhums
Copy link

madhums commented Jul 7, 2020

Can anyone merge this and do a release? Seems like an important fix!

@fcsonline
Copy link

Can this be merged? Is something blocking it?

@juancarlosqr
Copy link
Author

@fcsonline no blocker, the repo looks like is not maintained anymore :( any comment @rexxars?

@wooorm
Copy link
Member

wooorm commented Oct 8, 2020

You can use a plugin for that: https://github.com/remarkjs/remark-external-links

@wooorm wooorm closed this Oct 8, 2020
@wooorm wooorm added the 👀 no/external This makes more sense somewhere else label Oct 8, 2020
@wooorm wooorm mentioned this pull request Oct 8, 2020
@2manyvcos
Copy link

2manyvcos commented Oct 9, 2020

@wooorm That would be a preferable solution.
However, like stated in this comment, the suggested plugin sadly does not seem to work with react-markdown.

I just tried it but without success.

EDIT: NVM I just saw your other comment here

@wooorm
Copy link
Member

wooorm commented Oct 9, 2020

there’s a PR merged that solves that which will be released soon

@juancarlosqr juancarlosqr deleted the add-link-rel-tag branch October 9, 2020 13:43
@adarnon
Copy link

adarnon commented Oct 27, 2020

Has anyone managed to get remark-external-links to work? The new version has been released, but it looks like the plugin just isn't run.

@MorelSerge
Copy link

@adarnon I haven't been able to on 5.0.3

@wassim
Copy link

wassim commented Jan 30, 2021

remark-external-links still doesn't work... @wooorm please reopen the issue!

@statico
Copy link

statico commented Aug 2, 2021

As of August, 2021, remark-external-links seems to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 no/external This makes more sense somewhere else
Development

Successfully merging this pull request may close these issues.