-
-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rel tag to links #350
Add rel tag to links #350
Conversation
This looks great! I also have a need for this prop. Hopefully this can be merged soon. |
Any progress on merging this? Seems like a pretty crucial commit security wise |
Would be nice to be able to add optionally |
@rexxars: Friendly ping :-) if you get a chance to look at this, that’d |
Can anyone merge this and do a release? Seems like an important fix! |
Can this be merged? Is something blocking it? |
@fcsonline no blocker, the repo looks like is not maintained anymore :( any comment @rexxars? |
You can use a plugin for that: https://github.com/remarkjs/remark-external-links |
@wooorm That would be a preferable solution. I just tried it but without success. EDIT: NVM I just saw your other comment here |
there’s a PR merged that solves that which will be released soon |
Has anyone managed to get |
@adarnon I haven't been able to on 5.0.3 |
|
As of August, 2021, remark-external-links seems to work fine. |
Hi,
For security reasons external links should be able to have a
rel
tag (.e.g. "noopener noreferrer"). More info hereI created a
linkRel
option to add the tag, similar tolinkTarget
This is the first year I participate in the Hacktoberfest, so I'm open to any comments or feedback regarding my contribution 😉
Happy Hacktoberfest!