Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move disallowedTypes into base props in typings #496

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Move disallowedTypes into base props in typings #496

merged 1 commit into from
Oct 22, 2020

Conversation

js-williams
Copy link
Contributor

Closes GH-495

ChristianMurphy
ChristianMurphy approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @js-williams! 🙇

@wooorm wooorm merged commit 4dadaba into remarkjs:main Oct 22, 2020
@wooorm wooorm added ☂️ area/types This affects typings ⛵️ status/released 👶 semver/patch This is a backwards-compatible fix labels Oct 23, 2020
@wooorm
Copy link
Member

wooorm commented Oct 23, 2020

thanks, released in 5.0.2!

@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The allowedTypes and unwrapDisallowed props cannot be used together in TypeScript
3 participants
@js-williams @wooorm @ChristianMurphy