Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dev-dependency #846

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add missing dev-dependency #846

merged 1 commit into from
Jul 15, 2024

Conversation

mayank1513
Copy link
Contributor

@mayank1513 mayank1513 commented Jul 15, 2024 •
edited
Loading

  • added remark-gfm as dev dependency

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

added remark-gfm as dev dependency to fix the unit tests.

@mayank1513
Fix unit tests
5e10879 
- added remark-gfm as dev dependency
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jul 15, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 15, 2024
@wooorm
Copy link
Member

wooorm commented Jul 15, 2024

  • we use npm, so this shouldn‘t be a problem for you, use npm
  • sure, good to have

@wooorm wooorm merged commit fd337ff into remarkjs:main Jul 15, 2024
4 checks passed
@wooorm wooorm changed the title Fix unit tests Add missing dev-dependency Jul 15, 2024
@wooorm wooorm added 📦 area/deps This affects dependencies 💪 phase/solved Post is done labels Jul 15, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 15, 2024
@wooorm
Copy link
Member

wooorm commented Jul 15, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank1513 @wooorm @remcohaszing