-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mdast-util-newline-to-break
#10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @remcohaszing!
Remind me did the upstream package make any changes to the API?
I'm specifically asking to better understand the semver implications of this change.
The upstream API should be the same, but the implementation is based on #9 (comment). Note that it’s a drop-in replacement. No tests were modified. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 49 15 -34
=========================================
- Hits 49 15 -34
☔ View full report in Codecov by Sentry. |
mdast-util-newline-to-break
Released in 3.0.3! |
This comment was marked as resolved.
This comment was marked as resolved.
AFAICT, the use of |
All our packages are esm for years already. So no. Where did this comment come from? Did something break? How did you find this somewhat old issue? |
Sorry - I'd simply failed to include the new dep ( |
Oh is this remix still being broken 😬😬 |
Initial checklist
Description of changes
Replace the transformer with
mdast-util-newline-to-break
.Closes #9