-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: move to ESM, generated typescript types from JSDoc #44
feat!: move to ESM, generated typescript types from JSDoc #44
Conversation
opened transitive-bullshit/check-links#23 to add missing typings |
e77d795
to
e066051
Compare
Friendly ping @davidtheclark 🔔 An example of the build status/results https://github.com/ChristianMurphy/remark-lint-no-dead-urls/actions/runs/3483150219 |
Just checking in on this again, @davidtheclark what do you think about this PR? |
I am not really maintaining this anymore. I'd be happy to hand it off to anybody who would like to take over! |
Oh, @ChristianMurphy or @transitive-bullshit, would you be able to do some maintenance work on this? I think both of you would be better candidates than me. |
Heya @davidtheclark! To summarize the steps:
|
For step 2 above, I don’t think forking is a good idea. I’d rather you move the repo to one of us, then we can move to the org. For step 3, I’d ask: are you still interested in occasionally contributing to the repo? |
@ChristianMurphy @wooorm: I've initiated an ownership transfer to @wooorm -- I was unable to transfer directly to the |
Moved! Thanks :) |
Can you add me on npm too? https://www.npmjs.com/package/remark-lint-no-dead-urls |
@ChristianMurphy I believe you now have access to merge some of your work. Feel free to ask my reviews / merge stuff yourself / work on this repo for a bit. I can look into some of the docs/urls stuff in some of the coming days! |
Thanks @davidtheclark and @wooorm!
I'm going to land this PR now, and will probably open some smaller PR over the coming days.
Sounds good, thanks! |
This is a major version update, this makes several significant changes:
remarkjs
projectsStill TODOCompleted:likely,tape
node:test
andnode:assert
)check-links
Resolves #43 #28 #30 #33 #34 #36 #37 #40 #42