Bug: Different empty alt values for image, imageReference

[quantizor]

using mdast.parse():

mdast.parse("![](/xyz.png)")

Yields an AST node for image with alt set to null.

The same setup but using an imageReference instead:

mdast.parse("![][1]\n[1]: /xyz.png")

Yields an imageReference with alt set to "" (empty string)

[wooorm]

I agree, that isn’t very pretty. I’d go for the following here:

 } else if (type === 'image') {
-    node.alt = decode(self.descape(text), eat);
+    node.alt = decode(self.descape(text), eat) || null;
 }

The reason for null is because it’s in the imageReference definition.

Not that I suggest accept both null and undefined next to "", everywhere. It makes for more solid code. Although you’re building with mdast ingrained right now, maybe in the future you’ll allow plug-ins to manipulate the tree too, in which case they might (probably will) sometimes forget to add a property.

[wooorm]

This will be included in the upcoming release of mdast, 3.0.0, which I’ll expect to 🚢 before the new year.

[quantizor]

🎉