Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation note for pedantic mode #477

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Mar 27, 2020

Closes GH-470.

pedantic mode is buggy. It won’t be in micromark. This PR warns users not to use it.

@wooorm wooorm added 👶 semver/patch This is a backwards-compatible fix 📚 area/docs This affects documentation labels Mar 27, 2020
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a @deprecated annotation to pedanic in the typings?
And might we want to add a deprecation log in the code itself?

@wooorm
Copy link
Member Author

wooorm commented Mar 27, 2020

I wanted to do a “soft” one first, just docs, to signal that the pedantic code is basically frozen for future issues or new users. Hoping the next major after this one will be micromark.

@ChristianMurphy
Copy link
Member

Agreed, code wise I was thinking something like Node's depercate
https://github.com/nodejs/node/blob/1b1c2993a5bc9a64cb4d417509d2fc35a64182f4/lib/internal/util.js#L62-L102
Where it is a soft deprecation, but adds some logs to signal the incoming change, in case people haven't reviewed the docs.

@wooorm
Copy link
Member Author

wooorm commented Mar 27, 2020

My plan was to be even softer mostly due to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-transformer-remark/src/extend-node-type.js#L110 😬

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Mar 27, 2020

ah, that make sense.
CC'ing the Gatby team members who have recently worked on the remark integration to raise awareness.

/cc @pieh @sidharthachatterjee @wardpeet @DSchau

@wooorm wooorm merged commit 4a6dcc9 into master Mar 28, 2020
@wooorm wooorm deleted the soft-deprecate-pedantic branch March 28, 2020 08:27
wooorm pushed a commit that referenced this pull request Mar 28, 2020
Related-to GH-470.
Related-to GH-477.
Closes GH-480.

Reviewed-by: Titus Wormer <tituswormer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 👶 semver/patch This is a backwards-compatible fix
Development

Successfully merging this pull request may close these issues.

Underscores within links interfering with emphasis in pedantic mode.
2 participants