Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringify: add option to not put blank lines between definitions #501

Merged
merged 4 commits into from
Jun 8, 2020
Merged

stringify: add option to not put blank lines between definitions #501

merged 4 commits into from
Jun 8, 2020

Conversation

spl
Copy link
Contributor

@spl spl commented Jun 8, 2020

When one has a lot of consecutive definitions, remark-stringify adds a lot of extra vertical space when it inserts a blank line between each definition pair. This PR provides an option to change those two newlines between definition pairs into one.

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/remark-stringify/lib/defaults.js Outdated Show resolved Hide resolved
packages/remark-stringify/lib/macro/block.js Outdated Show resolved Hide resolved
* Change logic for tightDefinitions since the meaning of it is now
  reversed from definitionBlankLine.
* Rename definitionSeparator -> definitionGap
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

I feel these docs suggestions make it a bit better to read, but that’s subjective. What do you think?

packages/remark-stringify/readme.md Outdated Show resolved Hide resolved
packages/remark-stringify/readme.md Outdated Show resolved Hide resolved
spl and others added 2 commits June 8, 2020 20:20
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
@wooorm wooorm added remark-stringify 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Jun 8, 2020
@wooorm wooorm merged commit 31ac691 into remarkjs:master Jun 8, 2020
@wooorm
Copy link
Member

wooorm commented Jun 8, 2020

Released in 8.1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done remark-stringify 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

2 participants