Fix situation where label already exists on the card (#126)

rematocorp · Sep 18, 2024 · 42d11af · 42d11af
1 parent 2b77f10
commit 42d11af
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -34025,7 +34025,17 @@ async function addLabelToCards(conf, cardIds, head) {
         const boardLabels = await (0, trello_1.getBoardLabels)(cardInfo.idBoard);
         const matchingLabel = findMatchingLabel(branchLabel, boardLabels);
         if (matchingLabel) {
-            await (0, trello_1.addLabelToCard)(cardId, matchingLabel.id);
+            try {
+                await (0, trello_1.addLabelToCard)(cardId, matchingLabel.id);
+            }
+            catch (error) {
+                if (error.response?.data === 'that label is already on the card') {
+                    logger_1.default.log('Label already exists on the card', cardId, matchingLabel);
+                }
+                else {
+                    throw error;
+                }
+            }
         }
         else {
             logger_1.default.log('Could not find a matching label from the board', { branchLabel, boardLabels });
@@ -34342,7 +34352,7 @@ async function makeRequest(method, url, params) {
     }
     catch (error) {
         const errorMessage = {
-            message: 'Failed to make a request',
+            message: 'Trello request was rejected',
             method,
             url,
             params,

diff --git a/src/actions/addLabelToCards.test.ts b/src/actions/addLabelToCards.test.ts
@@ -10,6 +10,7 @@ jest.mock('./api/trello')
 const getCardInfoMock = getCardInfo as jest.Mock
 const getBoardLabelsMock = getBoardLabels as jest.Mock
 const getBranchNameMock = getBranchName as jest.Mock
+const addLabelToCardMock = addLabelToCard as jest.Mock
 
 const head = { ref: 'chore/clean-code' }
 const conf = { trelloAddLabelsToCards: true }
@@ -78,6 +79,23 @@ it('skips when correct label is already assigned', async () => {
 	expect(addLabelToCard).not.toHaveBeenCalled()
 })
 
+it('skips when correct label was just assigned moments ago', async () => {
+	getCardInfoMock.mockResolvedValueOnce({ id: 'card', labels: [] })
+	getBoardLabelsMock.mockResolvedValueOnce([{ id: 'chore-id', name: 'chore' }])
+	addLabelToCardMock.mockRejectedValue({ response: { data: 'that label is already on the card' } })
+
+	await addLabelToCards(conf, ['card'], head)
+})
+
+it('throws error when unexpected rejection comes from Trello', async () => {
+	getCardInfoMock.mockResolvedValueOnce({ id: 'card', labels: [] })
+	getBoardLabelsMock.mockResolvedValueOnce([{ id: 'chore-id', name: 'chore' }])
+
+	addLabelToCardMock.mockRejectedValue({ response: { status: 500 } })
+
+	await expect(addLabelToCards(conf, ['card'], head)).rejects.toMatchObject({ response: { status: 500 } })
+})
+
 it('skips when turned off', async () => {
 	getCardInfoMock.mockResolvedValueOnce({ id: 'card', labels: [] })
 	getBoardLabelsMock.mockResolvedValueOnce([{ id: 'chore-id', name: 'chore' }])

diff --git a/src/actions/addLabelToCards.ts b/src/actions/addLabelToCards.ts
@@ -35,7 +35,15 @@ export default async function addLabelToCards(conf: Conf, cardIds: string[], hea
 			const matchingLabel = findMatchingLabel(branchLabel, boardLabels)
 
 			if (matchingLabel) {
-				await addLabelToCard(cardId, matchingLabel.id)
+				try {
+					await addLabelToCard(cardId, matchingLabel.id)
+				} catch (error: any) {
+					if (error.response?.data === 'that label is already on the card') {
+						logger.log('Label already exists on the card', cardId, matchingLabel)
+					} else {
+						throw error
+					}
+				}
 			} else {
 				logger.log('Could not find a matching label from the board', { branchLabel, boardLabels })
 			}

diff --git a/src/actions/api/trello.ts b/src/actions/api/trello.ts
@@ -134,7 +134,7 @@ async function makeRequest(method: 'get' | 'put' | 'post' | 'delete', url: strin
 		return response
 	} catch (error: any) {
 		const errorMessage = {
-			message: 'Failed to make a request',
+			message: 'Trello request was rejected',
 			method,
 			url,
 			params,