Add functions to convert selection ranges #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LSP selection ranges define their parent selection range using the `parent` property. Monaco editor on the other hand, defines this ancestry as an array. This means that a singular Monaco editor selection range can’t be represented in LSP. This deprecates the functions `fromSelectionRange` and `toSelectionRange` in favor the plural variants `fromSelectionRanges` and `toSelectionRanges`.
remcohaszing
commented
Jun 7, 2024
| } | ||
|
|
||
| return result | ||
| } |
There was a problem hiding this comment.
@johnsoncodehk would you like to review this? I think it’s ok, but I would appreciate a second opinion, mostly to make sure I didn’t get the order wrong.
The toSelectionRanges implementation is based on https://github.com/microsoft/monaco-editor/blob/v0.49.0/src/language/common/lspLanguageFeatures.ts#L1015-L1022. The fromSelectionRanges implementation does the inverse.
|
LGTM! It would be nice to be consistent with upstream. |
johnsoncodehk
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP selection ranges define their parent selection range using the
parentproperty. Monaco editor on the other hand, defines this ancestry as an array. This means that a singular Monaco editor selection range can’t be represented in LSP.This deprecates the functions
fromSelectionRangeandtoSelectionRangein favor the plural variantsfromSelectionRangesandtoSelectionRanges.