Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autompletion not working in examples #227

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented Nov 1, 2023

fix #223

The language lexer in monaco-editor treats yaml's word as a string type.
https://github.com/microsoft/monaco-editor/blob/main/src/basic-languages/yaml/yaml.ts#L99

And the monaco-editor does not enable quick suggestions for string type by default.
https://github.com/microsoft/vscode/blob/main/src/vs/editor/contrib/suggest/browser/suggestInlineCompletions.ts#L134

So we should set quickSuggestions.strings to true to enable autocompletion, similar to what vscode-yaml does.
https://github.com/redhat-developer/vscode-yaml/blob/main/package.json#L233

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for monaco-yaml ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d1a585d
🔍 Latest deploy log https://app.netlify.com/sites/monaco-yaml/deploys/6543ac98796365000846d3dc
😎 Deploy Preview https://deploy-preview-227--monaco-yaml.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SyMind
Copy link
Contributor Author

SyMind commented Nov 2, 2023

@remcohaszing cc

@remcohaszing
Copy link
Owner

Thanks! This works great, but it only fixes it for the demo. The issue is about the monaco-editor-webpack-plugin examples.

Could you apply these changes to the other examples too?

@SyMind
Copy link
Contributor Author

SyMind commented Nov 2, 2023

@remcohaszing Of course. I have done.

@remcohaszing remcohaszing changed the title fix: autompletion not working in demo fix: autompletion not working in examples Nov 2, 2023
@remcohaszing remcohaszing merged commit 6ebf897 into remcohaszing:main Nov 2, 2023
4 checks passed
@remcohaszing
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autompletion not working in Example
2 participants