fix: autompletion not working in examples #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #223
The language lexer in
monaco-editor
treats yaml's word as a string type.https://github.com/microsoft/monaco-editor/blob/main/src/basic-languages/yaml/yaml.ts#L99
And the
monaco-editor
does not enable quick suggestions for string type by default.https://github.com/microsoft/vscode/blob/main/src/vs/editor/contrib/suggest/browser/suggestInlineCompletions.ts#L134
So we should set
quickSuggestions.strings
to true to enable autocompletion, similar to whatvscode-yaml
does.https://github.com/redhat-developer/vscode-yaml/blob/main/package.json#L233