correctly dup objects #516
Conversation
There was a problem hiding this comment.
Thanks for picking this up @KaylaGallatin 🎩 Had a few comments before merging 😺
lib/her/model/base.rb
Outdated
| def initialize_dup(other) | ||
| @_her_attributes = @_her_attributes.dup | ||
| @_her_attributes[self.class.primary_key] = nil | ||
|
|
There was a problem hiding this comment.
should we also run_callbacks :initialize here?
There was a problem hiding this comment.
should we also run_callbacks :initialize here?
lib/her/model/base.rb
Outdated
| @_her_attributes = @_her_attributes.dup | ||
| @_her_attributes[self.class.primary_key] = nil | ||
|
|
||
| @new_record = true |
There was a problem hiding this comment.
we can remove this since new_record? doesn't rely on an instance variable yet 😺
lib/her/model/base.rb
Outdated
| def initialize_dup(other) | ||
| @_her_attributes = @_her_attributes.dup | ||
| @_her_attributes[self.class.primary_key] = nil | ||
|
|
There was a problem hiding this comment.
To stick w/ ActiveRecord behavior, we'll also need to clear or assign nil to any association caches.
Associations which aren't included in the initial request are stored in separate instance variables following a @_her_association_<name> convention.
Associations which are part of the initial request are merged w/ @_her_attributes.
lib/her/model/base.rb
Outdated
| @@ -28,6 +28,17 @@ def [](attribute_name) | |||
| def singularized_resource_name | |||
| self.class.name.split('::').last.tableize.singularize | |||
| end | |||
|
|
|||
| # @private | |||
| def initialize_dup(other) | |||
There was a problem hiding this comment.
can we go ahead and move this to attributes.rb below initialize?
Move to attributes file Clear association keys and caches
Attempting to fix #355
After calling
dupon an object, changes made to either object would be applied to both objects. This fixes that issue so that both objects are independent of one another.