Support Faraday 1.0.X #537
Conversation
bvicenzo
force-pushed
the
bv-support-faraday-1.0
branch
3 times, most recently
from
2fec02f to
5c7471c
Compare
bvicenzo
force-pushed
the
bv-support-faraday-1.0
branch
from
5c7471c to
4686f70
Compare
|
Any ETA on getting this worked on ? Would really like this update. cc: @zacharywelch and @edtjones |
|
@zacharywelch @edtjones @remi Could you help us here? |
It would be a great assistance for my team (and for many other teams) if you guys could post any update on this topic. 👀 |
|
Hi @ptonella @bvicenzo thanks for chasing this. @zacharywelch and I are both snowed under with other stuff and haven't had time to maintain this gem at the moment; if you would like to continue this task we can ask @remi to add you as a committer. |
|
Just FIY, I've been using this gem fix in production since Jul 2020 this way: gem 'her', git: 'https://github.com/bvicenzo/her.git', branch: 'bv-support-faraday-1.0'And updated other dependencies to Faraday 1.X... It's working as expected... it may be considered a good test... |
|
Sorry everyone, I haven’t had the time to check on issues related to this project. @bvicenzo Would you like to help with this project as a maintainer? |
|
Man, thanks for the invite. |
|
@remi could you change the version to 1.1.1 in order to update the ruby gems: https://rubygems.org/gems/her. Because the version wasn't changed, the rubygem still have the previous version. To fasten things up I opened a PR: #541 |
|
@remi @thiagodiniz and I can help you with maintainer 👍 |
In this issue is discussed support to Faraday 1.0, Ruby 2.7, and Rails 6...
This PR intent to do one part of this, giving to users the possibility of using Faraday 1.0.X with Her gem...