Teamocil does not respect base-index

[kylebarbour]

When run from within an existing tmux session, Teamocil behaves as expected by opening a new window at the next available index number, and so no issue exists. However, when run at the start of a new session, Teamocil opens the first window at index 1, rather than the setting of base-index (default 0). This is an issue as it breaks expected behavior, particularly in that creating a new window within that tmux session will index it at 0, while you would naturally expect that window to be indexed in sequence.

Steps to reproduce:

1. Create a basic Teamocil configuration file (~/.teamocil/test.yml):

windows:
  - name: test

2. Create a new tmux session running Teamocil:
   $ tmux new-session "teamocil test"
3. Note that this creates a new session with a single window with index 1 rather than 0.

System information:

$ tmux -V
tmux 2.6
$ teamocil --version
1.4.2
$ lsb_release -d
Description:	Ubuntu 18.04.3 LTS
$ uname -sr
Linux 4.15.0-74-generic

[remi]

Hi Kyle,

Thank you for the bug report. I never use tmux new-session <command> so this is new to me. However, I’m not able to reproduce the bug on my system.

If I have base-index set to 0, running tmux new-session "teamocil test" creates a session with its only window at index 0.

If I have base-index set to 1, running tmux new-session "teamocil test" creates a session with its only window at index 1.

This line in Teamocil::Tmux::Window makes sure we use the correct base index from Tmux configuration.

My system information:

$ tmux -V
tmux 3.0
$ teamocil --version
1.4.2
$ uname -sr
Darwin 19.2.0

Can you try with a newer tmux version?

Thank you!

[kylebarbour]

Hey remi, thanks for the reply!

I just built the latest source and have the same problem.

$ git clone https://github.com/tmux/tmux.git && cd tmux
$ sh autogen.sh
$ ./configure
$ make
$ sudo make install
$ which tmux
/usr/local/bin/tmux
$ tmux -V
tmux next-3.1

Interestingly, it seems that teamocil does respect base-index. However, the window numbering is still offset by 1. In other words, if base-index is 0, the windows start at 1; if it is 1, then 2; if it is 8, then the windows start at 9.

This occurs with a minimal ~/.tmux.conf that only contains set -g base-index N.

[laureanray]

I'm still encountering this issue using the minimal configuration of Teamocil. Can I work on this? @remi