Homebrew deps #52
Closed
Homebrew deps #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
This was referenced Nov 7, 2023
irieger
suggested changes
Nov 7, 2023
| find_path(pystring_INCLUDE_DIR | ||
| NAMES | ||
| pystring/pystring.h | ||
| pystring.h |
There was a problem hiding this comment.
Running this in an Arch linux installation that has all the required libraries installed in system level results in the following include path: pystring_INCLUDE_DIR:PATH=/usr/include. However the correct path should be pystring_INCLUDE_DIR:PATH=/usr/include/pystring.
Only if I remove the pystring/pystring.h line from NAMES and add a line with include/pystring to PATH_SUFFIXES I get the correct path. Don't know how that might influence other combinations.
Owner
Author
There was a problem hiding this comment.
That makes sense @irieger, I just implemented those changes and tested locally, if the CI pass I'll open a PR upstream.
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.