Message Subject could be dynamically picked from the message so that we can publish to multiple NATS Subjects

[gdcrocx]

Hi @remil1000,

Appreciate the work you have done on the logstash-input-nats_streaming plugin for Logstash. I have gone through the code and just a suggestion -

Do you see if the NATS subject could be picked up dynamically from the incoming message subject?

Feel free to share your comments. Thanks, once again.

George Davis.
https://www.georgedavis.co

[gdcrocx]

With reference to the logstash-input-nats input plugin for Logstash by lliknart here (https://github.com/lliknart/logstash-input-nats/blob/master/lib/logstash/inputs/nats.rb), lliknart has made the acceptable subjects as an array.

Do you think we can use the same logic for your nats_streaming plugin?

[remil1000]

Hi @gdcrocx ,

I may handle this as a comma separated list of subjects
so for example subject => "sub1, sub2, sub3"
If I had to implement this multiple subjects setup I would still prefer separated logstash threads/pipelines for each subject to avoid some noisy neighbor side effects

Getting back to your first quetion, I'm not sure I'm understanding the "dynamic subject part"; remember this is a input plugin for NATS streaming (not pure NATS) so there is no support for subject name wildcard or hierarchy.

Please let me know if a simple list of sujbects would fit your need

[gdcrocx]

Hi @remil1000,

Thank you so much for looking into it. Yes, adding an array list of subjects would solve the issue.

Something like this, I would assume

config :subjects, :validate => :array, :default => ["logstash"]

Do keep me posted on this issue and I can help test the changes.

Thanks, once again.

[remil1000]

implemented in branch feature/multiple-subjects and tagged 0.2.1

Could you try 0.2.1 to see if it fits your need ?

[gdcrocx]

Hi @remil1000,

Checked the source code. Looks good. Will test tonight and keep you posted.

Any tips on why we are choosing to split strings rather than implementing an array of strings?

Thanks.

[remil1000]

I don't want to break current behavior changing type from string to array would break things on plugin upgrade (and also I'm lazy ;) )

…

On Thu, 18 Apr 2019 at 15:30, George Davis ***@***.***> wrote: Hi @remil1000 <https://github.com/remil1000>, Checked the source code. Looks good. Will test tonight and keep you posted. Any tips on why we are choosing to split strings rather than implementing an array of strings? Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIBAXO64NSFBDYR2BGXNEF3PRBZXDANCNFSM4HEAW7WQ> .

-- Rémi Laurent OpenPGP : 0x0FA00601