Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from tests with polymorphic serializer #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

khillion
Copy link
Collaborator

Here are some little fix from my own experience with the package.
I have also added a class ChangeField

@khillion khillion requested a review from remilapeyre August 30, 2018 17:02
@remilapeyre remilapeyre force-pushed the master branch 2 times, most recently from ffabe48 to 2010893 Compare August 31, 2018 09:05
@khillion
Copy link
Collaborator Author

It should be now possible to:

  • Specify several modification for one date using tuple, list or Generator
  • Use ChangeField (e.g, from CharField() to IntegerField() to perform corresponding modification in fields and payload.

Tests:

  • Unit test for ChangeField.update()
  • Add a new modification ChangeField to 2018-08-02 to have a tuple
  • All tests of TestVersionedSerializer actually check for the functionality of the ChangeField

fix the way to_representation is done for payload
@khillion khillion force-pushed the fix-from-test-with-polymorphic-serializer branch from 7a32ee1 to b2a356f Compare September 4, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants