Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prod as a protected environment. #24

Merged
merged 3 commits into from
Jan 7, 2016
Merged

Conversation

benguillet
Copy link
Contributor

No description provided.

@sanjayprabhu
Copy link

Yesssss! Thank you @benguillet

👍

var ProtectedEnvironments = map[string]bool{
"production": true,
var ProtectedEnvironments = map[string]struct{}{
"production": struct{}{},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but think I liked map[string]bool better.

@ejholmes
Copy link
Contributor

👍

@ejholmes
Copy link
Contributor

I wonder if it would be better to be able to set some aliases that get converted to the real thing. e.g. if you specify prod here it turns it into production before creating the github deployment. That would address my concern in remind101/empire#681 (comment).

@benguillet
Copy link
Contributor Author

@ejholmes this was my first idea, but since this is open sourced, what about people using this to match to an environment named prod? This would break it for them (deploy is versioned, but i feel like we should pass whatever environment the user wants and it's the server's job to support it).

@ejholmes
Copy link
Contributor

I was thinking more of making it configurable, like in a config file or an environment variable. Anyways, I don't think we need to block this on that. This method is still a good option and we can always change it later.

benguillet added a commit that referenced this pull request Jan 7, 2016
Add prod as a protected environment.
@benguillet benguillet merged commit 3af7f24 into master Jan 7, 2016
@benguillet benguillet deleted the prod-environment branch January 7, 2016 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants