-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prod as a protected environment. #24
Conversation
Yesssss! Thank you @benguillet 👍 |
a4beaac
to
31256db
Compare
var ProtectedEnvironments = map[string]bool{ | ||
"production": true, | ||
var ProtectedEnvironments = map[string]struct{}{ | ||
"production": struct{}{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but think I liked map[string]bool
better.
👍 |
I wonder if it would be better to be able to set some aliases that get converted to the real thing. e.g. if you specify |
@ejholmes this was my first idea, but since this is open sourced, what about people using this to match to an environment named |
I was thinking more of making it configurable, like in a config file or an environment variable. Anyways, I don't think we need to block this on that. This method is still a good option and we can always change it later. |
Add prod as a protected environment.
No description provided.