Added request logging to ecs custom resource. #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also ran `go fmt` modified: server/cloudformation/ecs.go
modified: pkg/cloudformation/customresources/customresources.go modified: server/cloudformation/ecs.go
modified: pkg/cloudformation/customresources/customresources.go modified: server/cloudformation/ecs.go
aengelas
reviewed
Aug 31, 2020
server/cloudformation/ecs.go
Outdated
| @@ -95,6 +95,9 @@ func newECSServiceProvisioner(resource *ECSServiceResource) *provisioner { | |||
| } | |||
|
|
|||
| func (p *ECSServiceResource) Create(ctx context.Context, req customresources.Request) (string, interface{}, error) { | |||
| // TODO: how to make this a debug log level? | |||
| fmt.Printf("%+v\n", req) | |||
There was a problem hiding this comment.
Suggested change
| fmt.Printf("%+v\n", req) | |
| fmt.Printf("%+v\n", *req.PropagateTags) |
I think you need to do that. That'll print the actual string referenced by req.PropagateTags.
|
This looks like it works, but I think that there's an edge case where you pass a customresources reference but the struct is missing one or more fields. I think that'll be a nil pointer error. I'll take a look at that in the morning. I think this should unblock you testing, @russellballestrini. |
aengelas
added a commit
to aengelas/empire
that referenced
this pull request
Sep 4, 2020
This reverts commit 7ab6b86.
aengelas
added a commit
to aengelas/empire
that referenced
this pull request
Sep 4, 2020
This reverts commit 7ab6b86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also ran
go fmt