Allow SSL certs to be updated on ELB's in ECS backend #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func (m *ELBManager) updateSSLCert(ctx context.Context, name, certID string) error { | ||
| _, err := m.elb.SetLoadBalancerListenerSSLCertificate(&elb.SetLoadBalancerListenerSSLCertificateInput{ |
There was a problem hiding this comment.
This should actually ensure that there's a 443 listener in case there was previously no cert attached.
|
Just realized that #662 actually still prevents this. I wonder if it would just be better if the UI for adding an SSL cert was more of an "attachment" flow: $ aws iam upload-server-certificate --server-certificate-name ProdCert$ emp cert-attach ProdCert -a <app>This would also fix #471, and make it more obvious what cert is attached to a load balancer. |
|
I'm all for changing the behavior to something like you're talking about, for all the reasons you mention. |
|
huge +1, this would be amazing |
ejholmes
added a commit
that referenced
this pull request
Dec 22, 2015
Allow SSL certs to be updated on ELB's in ECS backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the ECS backend to update the SSL cert on the associated ELB if it changes.
A better approach would be to provision resources using CloudFormation like talked about in #696, but that's a ways off and will require a substantial migration.