Add schema version check to db health check. #893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #891
This adds a check to the db health check that checks that the schema version matches what the running version of Empire expects. This means:
If you're in the process of upgrading to a new version of Empire, once the migrations are complete, older versions of Empire will start failing health checks and get taken out of the load balancer (assuming you have Empire behind a load balancer and are using the
/health
endpoint).If you try to start
empire server
with an incompatible database schema, you'll get an error message: