This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
Replace get_fqn references with AWS::StackName #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobologic
approved these changes
Mar 23, 2018
| "QueueName": "Fifo.fifo" | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Any idea where all these whitespace changes are coming from?
There was a problem hiding this comment.
No idea. It happened to @russellballestrini as well a while back: #163
get_fqn relies on stacker internals, and can change if you ever change the top level namespace of your config. AWS::StackName is more consistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_fqnrelies on stacker internals, and can change if you ever change the top level namespace of your config. AWS::StackName effectively solves the same problem, and won't change out from under you.Note, I left
get_fqnin stacker_blueprints/rds/base.py because changing it would break backwards compatibility. Everything else is just IAM policy names, which can be updated without issue.