Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the magicc version configurable #1274

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mikapfl
Copy link
Contributor

@mikapfl mikapfl commented Mar 30, 2023

Purpose of this PR

As a first step towards updating our magicc coupling, add configuration switches and configs to run REMIND with MAGICC7 instead of MAGICC6. We only have a magicc7 configuration for the default settings, not the full set of configs as we have for magicc6. Also, this PR does not include AR6-compatible pre-processing, we continue using the current code for that.

One pressing reason why we need magicc7 is that most likely magicc6 will not work on the new cluster (or only with a lot of effort).

The default magicc version remains magicc 6 for now, but this PR adds the option to change it to magicc7.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information:

We still need to do test runs. @LaviniaBaumstark

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

One pressing reason why we need magicc7 is that most likely magicc6 will not work on the new cluster (or only with a lot of effort).

I'm no friend of MAGICC's, but the last time we moved clusters, that wasn't a big deal … Any specific reason for that?

@mikapfl
Copy link
Contributor Author

mikapfl commented Mar 30, 2023

The main problem is libgfortran.so.3, which the magicc6 binary links to dynamically, but is not available on non-ancient linux versions anymore. It is possible to get it to work (I did it for my laptop once), but it is no fun.

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

Well, then … Kill it, kill it with fire!

@tonnrueter tonnrueter self-assigned this Feb 1, 2024
@gabriel-abrahao
Copy link
Contributor

@LaviniaBaumstark @tonnrueter For the cluster change, I think it's better to merge this here than to rush the climate-assessment PR. I think that one will be done in time, but nevertheless I don't think we want to retire the old capability so quickly.

@LaviniaBaumstark
Copy link
Member

@tonnrueter how to proceed with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants