Skip to content

chore: migrate examples to flat routes #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

chore: migrate examples to flat routes #201

wants to merge 5 commits into from

Conversation

mcansh
Copy link
Contributor

@mcansh mcansh commented Mar 31, 2023

gotta figure out the pathless example as there's a route conflict due to the new conflict detection of using urls and ids

⚠️ Route Path Collision: "/articles"

The following routes all define the same URL, only the first one will be used

🟢 routes/articles._layout.tsx
⭕️️ routes/articles.tsx

mcansh added 3 commits March 31, 2023 12:44
@mcansh
chore: bump remix to latest pre
ec120bd 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use flat routes
4f5cb7c 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: bump remix to latest
9e032fd 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/flat-routes branch from 0d0fabc to 9e032fd Compare March 31, 2023 20:20
mcansh added 2 commits March 31, 2023 16:29
@mcansh
chore: ext is inferred by plugins
c0937e2 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: order
0e3a3d2 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 31, 2023
Merged
@MichaelDeBoey
Copy link
Member

Closing in favor of #334

@MichaelDeBoey MichaelDeBoey deleted the logan/flat-routes branch August 31, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcansh @MichaelDeBoey