Reverse createHref and createPath warnings.

remix-run · Dec 14, 2015 · 38158d8 · 38158d8
1 parent e73011a
commit 38158d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -2,9 +2,11 @@
 > Unreleased
 
 - **Bugfix:** Don't throw in memory history when out of history entries ([#170])
+- **Bugfix:** Fix the deprecation warnings on `createPath` and `createHref` ([#189])
 
 [HEAD]: https://github.com/rackt/history/compare/latest...HEAD
 [#170]: https://github.com/rackt/history/pull/170
+[#189]: https://github.com/rackt/history/pull/189
 
 ## [v1.16.0]
 

diff --git a/modules/useQueries.js b/modules/useQueries.js
@@ -106,15 +106,15 @@ function useQueries(createHistory) {
 
     function createPath(location, query) {
       warning(
-        query,
+        !query,
         'the query argument to createPath is deprecated; use a location descriptor instead'
       )
       return history.createPath(appendQuery(location, query || location.query))
     }
 
     function createHref(location, query) {
       warning(
-        query,
+        !query,
         'the query argument to createHref is deprecated; use a location descriptor instead'
       )
       return history.createHref(appendQuery(location, query || location.query))