Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5 createPath issue with null values. was fine in v4 #907

Closed
salvoravida opened this issue Nov 16, 2021 · 1 comment
Closed

v5 createPath issue with null values. was fine in v4 #907

salvoravida opened this issue Nov 16, 2021 · 1 comment

Comments

@salvoravida
Copy link

push({pathname:'login', hash:null}) => url created "loginnull"

the problem is with the history v5:
https://github.com/remix-run/history/blob/main/packages/history/index.ts#L1052

it was fine with history v4
https://github.com/remix-run/history/blob/v4/modules/PathUtils.js#L56

related issue: salvoravida/redux-first-history#53
liuhanqu pushed a commit to liuhanqu/history that referenced this issue Nov 18, 2021
fix: remix-run#907
9105927
@liuhanqu liuhanqu mentioned this issue Nov 22, 2021
Closed
@brophdawg11
Copy link

This should have been fixed in 5.2.0 via #813. Could you check again and re-open if it's still an issue after 5.2.0? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #907 liuhanqu/history
2 participants
@brophdawg11 @salvoravida