Replace warning and invariant with tiny versions #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mjackson |
|
The build is broken. I'm trying to fix it now. |
|
Wait. I found one problem with them. Names are not provided and they are appear in bundle as |
`warning` and `invariant` packages are jealously maintained as mirrors of fbjs versions. Guys do not accept optimizations like esm. But happily there are alternatives. They are even more lightweight and save as 2kB of parsed (minified) code.
|
Done. Updated to latest versions. |
|
Thanks, @TrySound. This is good stuff. Makes me wanna do the same thing in all my repos! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warningandinvariantpackages are jealously maintained as mirrorsof fbjs versions. Guys do not accept optimizations like esm.
But happily there are alternatives. They are even more lightweight and
save for us 2kB of parsed (minified) code.