Support hashRoot in HashHistoryOptions #911

thejohnhoffer · 2021-12-09T23:56:50Z

Closes issue #912

Calling createHashHistory with hashRoot="" replicates the lost hashType="noslash" from history@4. This PR is to address issue #8459 and issue #7703 of react-router.

Update

Until this PR is merged, this is still possible with react-router-dom@6.1.1 and use-hash-history.

I accomplish this with a function to convert between history.location and window.location

packages/history/index.ts

thejohnhoffer · 2021-12-13T15:16:27Z

As it stands now, I'm currently using this solution with a fork of history.

UPDATE:
I'm currently using use-hash-history as a stand-in for this PR, following this template. It should be more maintainable than the fork.

chaance · 2021-12-17T19:53:28Z

Hey @thejohnhoffer, thanks for this! A couple of quick things:

It looks like this PR is only showing your change to your fork's docs. Can you fix that for us?
Can you set the base branch to dev? We merge code changes there (I should probably update that default in GitHub)

Thanks!

thejohnhoffer

According to the tests, this is a non-breaking change with added support of hashRoot: "" as a replacement for the lost feature of hashType: "noslash". For my purposes, this PR is now ready to merge.

thejohnhoffer · 2021-12-21T15:18:20Z

packages/history/__tests__/hash-test.js

@@ -21,12 +21,19 @@ import BlockPopWithoutListening from './TestSequences/BlockPopWithoutListening.j
 // const canGoWithoutReload = window.navigator.userAgent.indexOf('Firefox') === -1;
 // const describeGo = canGoWithoutReload ? describe : describe.skip;

-describe('a hash history', () => {
+export const testHashHistory = (initialRoot, options) => {


This function can test both createHashHistory() and createHashHistory({hashRoot: ""})

thejohnhoffer · 2021-12-21T15:19:34Z

packages/history/__tests__/hash-test.js

+    const { hashRoot = "/" } = options || {};
+    const historyHref = createPath(history.location);
+    const windowHref = window.location.hash.substr(1);
+    expect(historyHref.replace(/^\//, hashRoot)).toEqual(windowHref);


This solves issue #918

thejohnhoffer · 2021-12-21T15:23:20Z

packages/history/index.ts

+    return input.match(/^\.\.\//) ? partial : {
+      ...partial, pathname: input.replace(base, root)
+    };


Interchange hashRoot and '/' (unless the pathname starts with "../")

This solves issue #912.

thejohnhoffer · 2021-12-21T21:29:21Z

According to the tests, this is a non-breaking change with added support of hashRoot: "" as a replacement for the lost feature of hashType: "noslash". For my purposes, this PR is now ready to merge.

I'm happy to make any changes the maintainers decide should be made on this before merging. @chaance hopefully this PR is clearer to follow now, at only 35 lines of code (including tests).

thejohnhoffer · 2022-03-10T17:37:31Z

Hi @chaance -- I've again tested that the new and old tests all pass. My own alternative to this PR, use-hash-history, has a few users. I'm happy to continue maintaining my own package, but merging this PR would simplify the dependency tree of anyone who needs that feature.

I'm happy to simplify, remove, or re-write some of the tests I've created for this PR.

rahulgi · 2022-05-17T01:16:27Z

Adding a +1 to request that this PR gets merged, thanks for creating this, @thejohnhoffer!

marcinkowal2015 · 2022-06-17T09:58:17Z

+1 for this PR

hakubo · 2022-07-07T18:21:35Z

Any chance to move this PR forward?

hakubo · 2022-07-12T08:56:34Z

@chaance how could we help moving this forward?

hakubo · 2022-09-28T12:06:59Z

@chaance "This branch has no conflicts with the base branch" - anything we could do?

Mikilll94 · 2022-10-17T18:04:51Z

+1 for merging this PR

thejohnhoffer commented Dec 10, 2021

View reviewed changes

packages/history/index.ts Outdated Show resolved Hide resolved

thejohnhoffer mentioned this pull request Dec 10, 2021

[v6] HashRouter 'hashType' prop is no longer supported remix-run/react-router#7703

Closed

thejohnhoffer added 4 commits December 13, 2021 10:24

Update README.md

205d7cc

Update README.md

5a3bf6b

Update README.md

abb5625

Update README.md

e796aeb

thejohnhoffer mentioned this pull request Dec 13, 2021

Remove need for #/ with HashRouter basename="" remix-run/react-router#8460

Closed

This comment has been minimized.

Sign in to view

chaance changed the base branch from main to dev December 17, 2021 23:35

thejohnhoffer added 2 commits December 20, 2021 10:18

Merge branch 'dev' into main-for-react-router-noslash

ee3158c

simple solution for hashRoot parsing

59580ad

thejohnhoffer force-pushed the main-for-react-router-noslash branch from e8ef3ee to 59580ad Compare December 20, 2021 16:12

thejohnhoffer added 5 commits December 20, 2021 11:42

add basic tests for hashRoot=""

34db1b5

simplify further

78da42b

improve tests

45e710e

restore original tests

f595287

use original PushRelativePathnameWarning test

2bf3314

thejohnhoffer force-pushed the main-for-react-router-noslash branch 2 times, most recently from 657fc44 to 46bcb8e Compare December 20, 2021 19:20

handle all possible types for To

821d40c

thejohnhoffer force-pushed the main-for-react-router-noslash branch from 46bcb8e to 821d40c Compare December 21, 2021 12:02

thejohnhoffer added 3 commits December 21, 2021 07:21

improve tests

51a33ef

minor change to ensure pathname overwrites

077cc5f

handle relative pathnames

102165a

thejohnhoffer added 2 commits December 21, 2021 08:57

one fewer line

ec995a2

only ignore prefix when path matches ../

7f8c9d9

thejohnhoffer commented Dec 21, 2021

View reviewed changes

This was referenced Dec 21, 2021

Test improvement: observe window.location #918

Open

history compatibility: PR #911 thejohnhoffer/use-hash-history#10

Closed

thejohnhoffer mentioned this pull request Dec 22, 2021

911 thejohnhoffer/use-hash-history#13

Merged

Merge branch 'dev' into main-for-react-router-noslash

4afa6e5

thejohnhoffer mentioned this pull request Oct 18, 2022

[v6] Missing hashType={"noslash"} of HashRouter #953

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support hashRoot in HashHistoryOptions #911

Support hashRoot in HashHistoryOptions #911

thejohnhoffer commented Dec 9, 2021 •

edited

Loading

thejohnhoffer commented Dec 13, 2021 •

edited

Loading

chaance commented Dec 17, 2021

This comment has been minimized.

thejohnhoffer left a comment •

edited

Loading

thejohnhoffer Dec 21, 2021 •

edited

Loading

thejohnhoffer Dec 21, 2021

thejohnhoffer Dec 21, 2021 •

edited

Loading

thejohnhoffer commented Dec 21, 2021

thejohnhoffer commented Mar 10, 2022

rahulgi commented May 17, 2022

marcinkowal2015 commented Jun 17, 2022

hakubo commented Jul 7, 2022

hakubo commented Jul 12, 2022

hakubo commented Sep 28, 2022

Mikilll94 commented Oct 17, 2022

Support hashRoot in HashHistoryOptions #911

Are you sure you want to change the base?

Support hashRoot in HashHistoryOptions #911

Conversation

thejohnhoffer commented Dec 9, 2021 • edited Loading

Update

thejohnhoffer commented Dec 13, 2021 • edited Loading

chaance commented Dec 17, 2021

This comment has been minimized.

thejohnhoffer left a comment • edited Loading

Choose a reason for hiding this comment

thejohnhoffer Dec 21, 2021 • edited Loading

Choose a reason for hiding this comment

thejohnhoffer Dec 21, 2021

Choose a reason for hiding this comment

thejohnhoffer Dec 21, 2021 • edited Loading

Choose a reason for hiding this comment

thejohnhoffer commented Dec 21, 2021

thejohnhoffer commented Mar 10, 2022

rahulgi commented May 17, 2022

marcinkowal2015 commented Jun 17, 2022

hakubo commented Jul 7, 2022

hakubo commented Jul 12, 2022

hakubo commented Sep 28, 2022

Mikilll94 commented Oct 17, 2022

thejohnhoffer commented Dec 9, 2021 •

edited

Loading

thejohnhoffer commented Dec 13, 2021 •

edited

Loading

thejohnhoffer left a comment •

edited

Loading

thejohnhoffer Dec 21, 2021 •

edited

Loading

thejohnhoffer Dec 21, 2021 •

edited

Loading