fix: fix remix.init
#138
Merged
fix: fix remix.init
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
fix-convert-to-js
branch
from
83ff196 to
980e29f
Compare
MichaelDeBoey
commented
Aug 12, 2022
Comment on lines
+11
to
+13
| env: { | ||
| "cypress/globals": true, | ||
| }, |
There was a problem hiding this comment.
Without this we would either get ESLint errors about Cypress, cy, ... being undefined or we would need to declare these values ourselves in globals
Comment on lines
-97
to
-100
| /* | ||
| eslint | ||
| @typescript-eslint/no-namespace: "off", | ||
| */ |
There was a problem hiding this comment.
This one's unused, so no need to set it to "off" here
Comment on lines
+13
to
+15
| .replace(new RegExp("npx ts-node", "g"), "node") | ||
| .replace(new RegExp("create-user.ts", "g"), "create-user.js") | ||
| .replace(new RegExp("delete-user.ts", "g"), "delete-user.js"); |
There was a problem hiding this comment.
We have these values both in code & in comments
Comment on lines
+49
to
+51
| isTypeScript | ||
| ? Promise.resolve() | ||
| : fs.readFile(filePath, "utf-8").then(parseFunction); |
There was a problem hiding this comment.
We don't need to parse the value when we're not reading a file (when using TS)
| @@ -68,12 +68,9 @@ const updatePackageJson = ({ APP_NAME, isTypeScript, packageJson }) => { | |||
| name: APP_NAME, | |||
| devDependencies: isTypeScript | |||
| ? devDependencies | |||
| : removeUnusedDependencies(devDependencies, [ | |||
| "ts-node", | |||
| "vite-tsconfig-paths", | |||
There was a problem hiding this comment.
vite-tsconfig-paths is still used now that it supports jsconfig.json files
| prisma: isTypeScript | ||
| ? prisma | ||
| ? { ...prisma, seed: prismaSeed } |
There was a problem hiding this comment.
prisma is a rest value (without prismaSeed), so we need to add the seed script again when using TS
This was referenced Aug 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the solution is also a change in the transform, which is implemented in remix-run/remix#3987
This will partially resolve #134
Closes #136
Closes #139
Closes #140