feat: enable v2_errorBoundary flag
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
enable-v2_errorBoundary-flag
branch
from
d09702d
to
9a637fd
Compare
brophdawg11
reviewed
Mar 24, 2023
app/routes/notes/$noteId.tsx
Outdated
| @@ -46,18 +51,20 @@ export default function NoteDetailsPage() { | |||
| ); | |||
| } | |||
|
|
|||
| export function ErrorBoundary({ error }: { error: Error }) { | |||
| console.error(error); | |||
There was a problem hiding this comment.
We may want to keep this. Render errors should get logged by our internal componentDidCatch but this would have also previously logged loader/action errors
brophdawg11
approved these changes
Mar 24, 2023
MichaelDeBoey
force-pushed
the
enable-v2_errorBoundary-flag
branch
from
9a637fd
to
4da2caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See remix-run/remix#5838