-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
temporarily only use one build in export map (#12437)
With the export map before this commit, there’s a react router context mismatch in react-router-dev because the node process from `react-router dev` isn’t started with `—conditions development`, so it required the production build of `react-router` (because it’s used internally in `react-router-dev`. Then for the server render, “react-router” is already in the cache so if any node_modules have a peer dep on it, it gets the production build too. After that, app code runs and asks for “react-router” but this import is processed through vite with the “development” condition, so the app gets a different version of react router Now if a node_module want’s to useLocation inside of the app, it’s got a different copy of that hook and no router context This is a temporary patch until we can work out how to get `react-router dev` to get the development build in node without requiring apps to set the conditions
- Loading branch information
1 parent
aed1b45
commit 5ce8667
Showing
2 changed files
with
24 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"react-router": patch | ||
--- | ||
|
||
temporarily only use one build in export map so packages can have a peer dependency on react router |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters