Fix shouldRevalidate on fetcher action redirect (#9782)

remix-run · Dec 22, 2022 · 672a903 · 672a903
1 parent 159b988
commit 672a903
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/.changeset/swift-bottles-cheat.md b/.changeset/swift-bottles-cheat.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/router": patch
+---
+
+Fix fetcher shouldRevalidate
diff --git a/packages/router/__tests__/router-test.ts b/packages/router/__tests__/router-test.ts
@@ -2068,15 +2068,10 @@ describe("a router", () => {
           "currentParams": Object {},
           "currentUrl": "http://localhost/",
           "defaultShouldRevalidate": true,
-          "formAction": "/fetch",
-          "formData": FormData {},
-          "formEncType": "application/x-www-form-urlencoded",
-          "formMethod": "post",
           "nextParams": Object {},
           "nextUrl": "http://localhost/",
         }
       `);
-      expect(Object.fromEntries(arg.formData)).toEqual({ key: "value" });
 
       router.dispose();
     });

diff --git a/packages/router/router.ts b/packages/router/router.ts
@@ -1416,7 +1416,6 @@ export function createRouter(init: RouterInit): Router {
       updateState({ fetchers: new Map(state.fetchers) });
 
       return startRedirectNavigation(state, actionResult, {
-        submission,
         isFetchActionRedirect: true,
       });
     }
@@ -1512,7 +1511,7 @@ export function createRouter(init: RouterInit): Router {
 
     let redirect = findRedirect(results);
     if (redirect) {
-      return startRedirectNavigation(state, redirect, { submission });
+      return startRedirectNavigation(state, redirect);
     }
 
     // Process and commit output from loaders