Fix encoded # in path parameter causes route to be evaluated differently

remix-run · Sep 12, 2024 · 931d865 · 931d865
1 parent 7372aff
commit 931d865
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/contributors.yml b/contributors.yml
@@ -282,3 +282,4 @@
 - yuleicul
 - zeromask1337
 - zheng-chuang
+- dunnai
diff --git a/packages/router/history.ts b/packages/router/history.ts
@@ -694,6 +694,7 @@ function getUrlBasedHistory(
     // pre-encode them since they might be part of a matching splat param from
     // an ancestor route
     href = href.replace(/ $/, "%20");
+    href = typeof to === "string" ? href.replace(/#/, "%23") : href
     invariant(
       base,
       `No window.location.(origin|href) available to create URL for href: ${href}`