Add back basename support in match()

remix-run · Feb 10, 2016 · d4a925a · d4a925a · fiowind · Sep 24, 2016
1 parent 1a81557
commit d4a925a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/modules/__tests__/serverRendering-test.js b/modules/__tests__/serverRendering-test.js
@@ -152,6 +152,16 @@ describe('server rendering', function () {
     })
   })
 
+  it('accepts a basename option', function (done) {
+    match({ routes, location: '/dashboard', basename: '/nasebame' }, function (error, redirectLocation, renderProps) {
+      const string = renderToString(
+        <RouterContext {...renderProps} />
+      )
+      expect(string).toMatch(/\/nasebame/)
+      done()
+    })
+  })
+
   describe('server/client consistency', function () {
     // Just render to static markup here to avoid having to normalize markup.
 

diff --git a/modules/createMemoryHistory.js b/modules/createMemoryHistory.js
@@ -1,4 +1,5 @@
 import useQueries from 'history/lib/useQueries'
+import useBasename from 'history/lib/useBasename'
 import baseCreateMemoryHistory from 'history/lib/createMemoryHistory'
 
 export default function createMemoryHistory(options) {
@@ -7,7 +8,7 @@ export default function createMemoryHistory(options) {
   // `useQueries` doesn't understand the signature
   const memoryHistory = baseCreateMemoryHistory(options)
   const createHistory = () => memoryHistory
-  const history = useQueries(createHistory)(options)
+  const history = useQueries(useBasename(createHistory))(options)
   history.__v2_compatible__ = true
   return history
 }