Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: shouldRevalidate missing FormData if action called by fetcher.submit returns (or throws) a redirect. #10176

Closed
nicksrandall opened this issue Mar 8, 2023 · 1 comment · Fixed by #10208
Closed

[Bug]: shouldRevalidate missing FormData if action called by fetcher.submit returns (or throws) a redirect. #10176

nicksrandall opened this issue Mar 8, 2023 · 1 comment · Fixed by #10208
Labels
bug

Comments

@nicksrandall
Copy link

What version of React Router are you using?

v6.8.2

Steps to Reproduce

  • Create action that throws a redirect.
  • Send "POST" to that action using fether.submit
  • Notice that shouldRevalidate is called but it does not include the formData that was originally sent.

Expected Behavior

  • I would expect that I would still have access to the formData that caused the redirect.

Actual Behavior

  • formData and formMethod are both undefined when action throws redirect.

As a side note, useSubmit works as expected.
@brophdawg11 brophdawg11 mentioned this issue Mar 15, 2023
Merged
@brophdawg11 brophdawg11 linked a pull request Mar 15, 2023 that will close this issue
Provide fetcher submission to shouldRevalidate if fetcher action redirects #10208
Merged
@brophdawg11 brophdawg11 self-assigned this Mar 15, 2023
@brophdawg11 brophdawg11 added the awaiting release This issue have been fixed and will be released soon label Mar 16, 2023
@brophdawg11
Copy link
Contributor

This should be fixed in 6.10.0 👍

@brophdawg11 brophdawg11 removed the awaiting release This issue have been fixed and will be released soon label Mar 29, 2023
@brophdawg11 brophdawg11 removed their assignment Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide fetcher submission to shouldRevalidate if fetcher action redirects remix-run/react-router
2 participants
@brophdawg11 @nicksrandall