Provide fetcher submission to shouldRevalidate if fetcher action redirects #10208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 72d8e07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Mar 15, 2023
| @@ -1825,12 +1833,12 @@ describe("a router", () => { | |||
| expect(rootLoader.mock.calls.length).toBe(1); | |||
| expect(shouldRevalidate.mock.calls[0][0]).toMatchObject({ | |||
| currentParams: {}, | |||
| currentUrl: new URL("http://localhost/child"), | |||
| currentUrl: expect.URL("http://localhost/child"), | |||
There was a problem hiding this comment.
Found out that new URL inside toMatchObject doesn't actually validate the internal URL 🤦 , so added the custom matcher and changed all existing instances. Thankfully no false positives.
brophdawg11
commented
Mar 15, 2023
Comment on lines
+2280
to
+2283
| "formAction": "/fetch", | ||
| "formData": FormData {}, | ||
| "formEncType": "application/x-www-form-urlencoded", | ||
| "formMethod": "post", |
There was a problem hiding this comment.
Fetcher submission should be included to shouldRevalidate if the fetcher action redirected
mcansh
approved these changes
Mar 16, 2023
This was referenced Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10176