Named params exclude . character

[ydnar]

In utils/Path.js:28, the regular expression ([^./?#]+) excludes . (dot) characters from named params. While the rest (/ ? #) seem to make sense to exclude from a / delimited parameterized path, dots can be present in path components. We use dotted params in Domainr, e.g.:

• https://domai.nr/godaddy.com
• https://domai.nr/foo.ap/with/foo.app

Consider dropping the . constraint? ([^/?#]+) Possible to monkeypatch this?

[mjackson]

This is by design. :) If you'd like to match the . character, use a *

<!-- Match "godaddy.com" -->
<Route path="*">
<!-- Match "foo.ap/with/foo.app" -->
<Route path="*/with/*">

Keep in mind that when using multiple *, this.props.params.splat will be an array. Otherwise, it will be a string.

Does that work?

[mjackson]

@ydnar On second thought, let's just remove the . from that RegExp. It's not terribly useful in URLs.

[mjackson]

@ydnar Wanna do a PR ? :D

[ydnar]

Hah! Whiplash. Will send a PR.

[ydnar]

Done.

Randy

On Wed, Sep 3, 2014 at 12:15 PM, Michael Jackson notifications@github.com
wrote:

@ydnar https://github.com/ydnar Wanna do a PR ? :D

—
Reply to this email directly or view it on GitHub
#259 (comment).

[mjackson]

Boom

[mjackson]

Thanks @ydnar!